Skip to content

chore: Check starters on CI + Remove 2332 port override #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Mar 26, 2025

Conversation

justinvdm
Copy link
Collaborator

@justinvdm justinvdm commented Mar 26, 2025

CI checks

To be more sure we're giving people working code to base their applications on, this PR adds a github workflow that run the following on CI for each starter:

  • ts typechecks
  • pnpm dev and check that cURL-ing it comes back with a 200
  • pnpm preview (which also does pnpm build) and check that cURL-ing it comes back with a 200

New package.json scripts in starters

  • pnpm check: runs tsc (users can change it to do other checks too if desired)
  • pnpm preview: builds then run vite preview

No more port setting

We no longer set a port (2332) for the dev server - this was a remnant of where we started when building the sdk that we don't need anymore. This means vite dev will now use its own default port (5173), and that users can do pnpm dev --port <PORT> to override this.

dev:init is now db agnostic

As long as a project has migrate:dev and seed scripts in their package.json, we'll run them on postinstall (previously we only ran them if we found a prisma schema). This means the drizzle starter also only needs pnpm i && pnpm dev to get a running server

Copy link

cloudflare-workers-and-pages bot commented Mar 26, 2025

Deploying redwood-sdk-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: d8e6c07
Status: ✅  Deploy successful!
Preview URL: https://6f00a998.redwood-sdk-docs.pages.dev
Branch Preview URL: https://check-starters-on-ci.redwood-sdk-docs.pages.dev

View logs

@justinvdm justinvdm changed the title chore: Check starters on CI chore: Check starters on CI + Remove 2332 port override Mar 26, 2025
@justinvdm justinvdm merged commit 4115cfb into main Mar 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant